Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img_path in posts doesn't work properly #21

Closed
ruzickap opened this issue Nov 12, 2022 · 1 comment
Closed

img_path in posts doesn't work properly #21

ruzickap opened this issue Nov 12, 2022 · 1 comment

Comments

@ruzickap
Copy link

Hello.

I saw in your posts statements like:

img_path: /assets/screenshots/2022-10-12-using-github-checks-api
image:
path: status-check.gif

This seems not to be working properly, because then the generated page https://josh-ops.com/posts/using-github-checks-api/index.html contains wrong image location 'https://josh-ops.com/status-check.gif' which obviously doesn't exist:

curl https://josh-ops.com/posts/using-github-checks-api/index.html | grep 'https://josh-ops.com/status-check.gif'

Maybe it would be better to use:

https://github.com/cotes2020/jekyll-theme-chirpy/blob/48f14e39ac81bbfb3b9913ea3ee789d775b2d1ae/_posts/2019-08-08-text-and-typography.md?plain=1#L9-L10

^^^ That is working correctly with images...

Maybe the bug is somewhere else, but I just wanted to let you know...

@joshjohanning
Copy link
Owner

Ahh! Good find @ruzickap.

It looks like the <meta property="og:image" meta tag is used when sharing on social media (link).

It looks like it's a bug, because as it's stated here:

In addition, the [img_path](https://chirpy.cotes.page/posts/write-a-new-post/#image-path) can also be passed to the preview image, that is, when it has been set, the attribute path only needs the image file name.

Reported the 🐛 upstream! cotes2020/jekyll-theme-chirpy#754 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants