-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for unordered list #44
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 7 7
Lines 489 492 +3
=====================================
- Misses 489 492 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It has some problems, but it's better than what was there before.
Given this input (from TEST.md):
![image](https://private-user-images.githubusercontent.com/381361/369027572-c34ef17b-264e-4271-ae45-e5867c1f9b6c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODY4MDIsIm5iZiI6MTczOTI4NjUwMiwicGF0aCI6Ii8zODEzNjEvMzY5MDI3NTcyLWMzNGVmMTdiLTI2NGUtNDI3MS1hZTQ1LWU1ODY3YzFmOWI2Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNTA4MjJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YmE5NGFkNzRhMTE3NGViYjFkNmU0ZjFiZTRhOTcyMzliMjJkMTc1YzE2Y2Q0OTE1OTMzMDE1ZjNlY2UyYzg0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.1FVxPxYd740_YIlvKjqS6ZrWvSJxQn-pbM15Uok0WVM)
This produces:
![image](https://private-user-images.githubusercontent.com/381361/369027653-0a3c83cd-9886-420b-b268-0f05b7b8fa89.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODY4MDIsIm5iZiI6MTczOTI4NjUwMiwicGF0aCI6Ii8zODEzNjEvMzY5MDI3NjUzLTBhM2M4M2NkLTk4ODYtNDIwYi1iMjY4LTBmMDViN2I4ZmE4OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNTA4MjJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NmI4NDk1ZmQ0NTM5MWIzOWMwOWFiNWU0NjllZWE5YjdmZGQ5NzI4ODUwOTUyOGExN2Q3ZTgzMGQ1ZmU0YTU1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.G7ZdokpPazcDo8dyGrakjDuTeVhPPHf3JfD68fkIDZE)
Input
- Item 1
- Item 2 (currently buggy)
- Item 2a
- Item 2b
Output
- Item 1
- Item 2a
- Item 2b
Which is better than what was there already.
I refactored this change to use None instead of 0 as the indicator of an unordered list in the list_index stack and will push it to your branch. If you git pull
your branch, you can bring that change to your local and continue working on this.
I believe the bug is fixed. It's slightly hacky but I found that for nested lists, the item's end tag is emitted after the nested list block, not before. |
Thanks for fixing this. It makes sense to me why it was broken now. In #45, I'm in the process of refactoring this to be a bit better about how the temporary line is handled. Instead of keeping a The PR is work in progress, so there's parts which are fully commented out / deleted that are not yet working. Maybe take a look and see whether you think this approach would make this less hacky? |
No description provided.