This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
feat!: remove title from Popup::new #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `Popup::new` method no longer accepts a title
parameter. Instead, the title can be set using the `title` method on the
`Popup` instance.
```diff
- let popup = Popup::new("tui-popup demo", "Press any key to exit")
+ let popup = Popup::new("Press any key to exit")
+ .title("tui-popup demo")
.style(Style::new().white().on_blue());
```
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 2 -1
Lines 133 130 -3
=====================================
+ Misses 133 130 -3 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
Popup::newmethod no longer accepts a titleparameter. Instead, the title can be set using the
titlemethod on thePopupinstance.