Correct URL ownership issue.

[plablo]

It was returning just after testing if the user is an Editor.
Now it checks the ownership of the URL too.

[plablo]

Affects Issue #15 .

[madmaharaja]

Yep, have the same or similar problem:
In my case "editors" can delete or edit links created by other users but not their own links.

[sathish1981]

@plablo : Your solution works fine. Now the editors and contributors can edit their own links.
But Contributors cannot edit Anon links. so somewhere the access rights for editing anonymous users links was gone.

[sathish1981]

@plablo @joshp23
After your fix, editor not able to edit contributors link anymore. Please let me know if you can replicate that.

[sathish1981]

Update,
Actually for Editor, he cannot take any actions on contributor links like edit, delete, share or stats is not working
Like the same, Contributor cannot take any actions on Anon links as well.

As you said in your document, edit and delete for editor to contributors links can be limited but why he cannot share and see stats of it?

In your Document as below,
Editor - Can add (+API), access own and all others', edit & delete own & anon URL's, not tracked on any
Contributor - Can add (+API), access own and anon's, and edit & delete own URLs, not tracked on own

[joshp23]

I haven't had much time to dig into this, but I suspected this pull request would result in loss of other functions. I have some time this weekend... I hope to explore this issue.

[joshp23]

@plablo I appreciate your work here. I rewrote that entire function, which was a mess.

[sathish1981]

@joshp23
Let me test and let u know

[sathish1981]

@joshp23
I tested your fix. As you stated, Admin and Contributor is working fine but editor has unlimited access.
Editor was having all rights like Admin. He can able to edit and delete all urls.

Somewhere editor role got messed up.

[joshp23]

editor should be able to edit and delete all urls. that's how I've set up the default. the editor cannot manage plugins, or site settings.

[sathish1981]

Thanks for the response :) I really appreciate your work.