feat: added base flask setup #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh-josh
reviewed
Jul 8, 2024
| app = Flask(__name__) | ||
|
|
||
| # Load data endpoint | ||
| @app.route('/loaddata', methods=['GET']) |
There was a problem hiding this comment.
please use /load-data as api endpoint here
sourabh-josh
reviewed
Jul 8, 2024
|
|
||
| # Load data endpoint | ||
| @app.route('/loaddata', methods=['GET']) | ||
| def loaddata(): |
There was a problem hiding this comment.
please make use of snake_case for function definations
sourabh-josh
reviewed
Jul 8, 2024
| data = request.json | ||
| user_query = data.get('query') | ||
|
|
||
| if user_query is None: |
There was a problem hiding this comment.
consider re-writing this falsy check as
if not user_query:
return jsonify({"error": "Query parameter 'query' is required."}), 400
sourabh-josh
reviewed
Jul 8, 2024
|
|
||
| def response_generator(user_query,loader): | ||
| Settings.llm = Ollama(model="llama3") | ||
| if loader.index is None: |
There was a problem hiding this comment.
if not loader.index:
raise ValueError("Index is not loaded. Call load_data first.")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1
base project setup with api endpoints
GET /loaddataloads data from local drive into vectorDBPOST /generategenerates response with the query