Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: upgrade to Multicall3 #45

Closed
mds1 opened this issue Aug 31, 2022 · 1 comment · Fixed by #46
Closed

feature request: upgrade to Multicall3 #45

mds1 opened this issue Aug 31, 2022 · 1 comment · Fixed by #46

Comments

@mds1
Copy link
Contributor

mds1 commented Aug 31, 2022

Looks like you currently maintain a hardcoded mapping of networks to addresses, and need to deploy a new contract and update that for each chain users want supported. If you migrate to Multicall3 you'll support more chains with less maintenance (I'm biased of course, but I do think it'll be easier for you).

It's fully backwards compatible, and adds a few new methods to offer users more granularity over reverting calls.

Looks like etherlite is the only chain Multicall3 isn't deployed on that this lib currently supports: if people actually use that and you need to maintain compatibility, we just need someone to fund to the Multicall3 deployer account (0x05f32B3cC3888453ff71B01135B34FF8e41263F2) and I can deploy it on that chain.

@joshstevens19
Copy link
Owner

Hey man! Thanks for raising this - for sure would love to upgrade happy if you wanted to do a PR (should be very easy) if not il add it to my todo list and get it done for us! Would love to support multicall3 for everything and we can try to sort etherlite but for now that using v2 is fine IMO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants