feat: switch to multicall3 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this.. Haha yep sorry > #1 I did this repo a while ago and never had or should I say made time to add tests.. but I can easily do an E2E test il fetch and test this out over weekend thanks for doing it! one thing could you update the readme supported chains ? |
|
README updated! |
joshstevens19
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
approved pending manual test over weekend thanks again @mds1
|
this is now deployed thanks a lot |
|
Awesome, thank you! 🙌 |
PriestBera
pushed a commit
to PriestBera/ethereum-multicall
that referenced
this pull request
May 18, 2024
feat: switch to multicall3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
I didn't update the ABI to include the new Multicall3 methods since it's not deployed on etherlite. I confirmed it built successfully, but I didn't see any tests so I'm not sure how to verify I didn't break anything 😅
All chains are still present and many new ones added, but the sort order is now based on that of the Multicall3 readme so the diff is a bit wonky.