Added starknet to list of networks #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starknet and starknet testnet network are added to the previous lists
joshstevens19
approved these changes
Feb 24, 2024
|
Thank you for accepting the pull request. Please can you help update the
JSON file on the scroll repo with my details only past contributors have
the access now
Maxwell# Checklist ✅
- [x] I've read [CONTRIBUTIONS.md](
https://github.com/scroll-tech/contribute-to-scroll/blob/main/CONTRIBUTIONS.md)
document
- [x] I've filled the `contributions.json` file
# Issues this PR Resolves 🚀
- Link to the Issue: https://github.com/joshstevens19/ethereum-multicall
- Link to the resolving PR on 3rd party repo:
#86
# Contributor social handles (Github / Twitter / Telegram) 🎙️
- Github: https://github.com/Dr-Maxwell
- Twitter: https://x.com/Max_wellBXO?t=eZ8pf2WnBQ4Uuqt3EtFVGg&s=09
- Github: Dr-Maxwell
# Contribution Description 📝
This pull request adds support for the StarkNet network in the existing
switch statement. It includes cases for StarkNet and StarkNet testnet along
with corresponding contract addresses. I followed a consistent pattern used
for other networks to ensure clarity and ease of use for users interacting
with contracts on these networks.
# Additional Resources 🔗
- Contract addresses:
- StarkNet: 0xc662c410C0ECf747543f5bA90660f6ABeBD9C8c4
- StarkNet Testnet: 0xde29d060D45901Fb19ED6C6e959EB22d8626708e
- Links to related code:
-
https://github.com/Dr-Maxwell/ethereum-multicall/blob/master/src/multicall.ts
…On Sun, 25 Feb 2024, 12:24 am Josh Stevens, ***@***.***> wrote:
Merged #86 <#86>
into master.
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYZ6MTEUCISTQI7SWOFNPCLYVJZCHAVCNFSM6AAAAABDRYXYFWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHEYTCNZZHA2DKNY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
PriestBera
pushed a commit
to PriestBera/ethereum-multicall
that referenced
this pull request
May 18, 2024
Added starknet to list of networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the StarkNet network in the existing switch statement. The StarkNet network, along with its testnet variants, are now included to provide users with seamless integration when interacting with contracts on these networks.