Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm values #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mateo-moon
Copy link

  • Fix bug with graphql won't starting by increasing requested RAM to 600Mi
  • Change image to rindexer-bundled

  - Fix bug with graphql won't starting by increasing requested RAM to 600Mi
  - Change image to rindexer-bundled
Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rindexer-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 0:38am

@joshstevens19
Copy link
Owner

Thanks for PR @mateo-moon - Can you cross check the docs:

https://github.com/joshstevens19/rindexer/blob/master/documentation/docs/pages/docs/deploying/aws.mdx#22-configure-the-valuesyaml-file

https://github.com/joshstevens19/rindexer/blob/master/documentation/docs/pages/docs/deploying/gcp.mdx#22-configure-the-valuesyaml-file

And fix anything related like the image and any mention of memory etc (not sure it does)

@mateo-moon
Copy link
Author

Thanks for PR @mateo-moon - Can you cross check the docs:

https://github.com/joshstevens19/rindexer/blob/master/documentation/docs/pages/docs/deploying/aws.mdx#22-configure-the-valuesyaml-file

https://github.com/joshstevens19/rindexer/blob/master/documentation/docs/pages/docs/deploying/gcp.mdx#22-configure-the-valuesyaml-file

And fix anything related like the image and any mention of memory etc (not sure it does)

Sure. Also we use different rindexer.yaml obviously. Let me know if you want me to add changes for helm chart to be generic about rindexer.yaml.

@joshstevens19
Copy link
Owner

joshstevens19 commented Dec 31, 2024

Thanks for PR @mateo-moon - Can you cross check the docs:
https://github.com/joshstevens19/rindexer/blob/master/documentation/docs/pages/docs/deploying/aws.mdx#22-configure-the-valuesyaml-file
https://github.com/joshstevens19/rindexer/blob/master/documentation/docs/pages/docs/deploying/gcp.mdx#22-configure-the-valuesyaml-file
And fix anything related like the image and any mention of memory etc (not sure it does)

Sure. Also we use different rindexer.yaml obviously. Let me know if you want me to add changes for helm chart to be generic about rindexer.yaml.

Yeah our yaml is just to get people setup we expect people to change it but if you spot something in the helm which can be more generic for sure!

@joshstevens19
Copy link
Owner

@mateo-moon how you getting on with this?

@mateo-moon
Copy link
Author

@mateo-moon how you getting on with this?

Hey, @joshstevens19, I ran more tests and found that the numbers I came up with were not correct. There is no consistency in how much is good to set. One run might work with 500Mi, but the next could fail. The only consistent behavior I’ve observed is when no resources are defined.

I don’t know why this is happening. I’m using AWS instances in an EKS cluster, so maybe it’s related to that. But I don’t have time right now to test it properly.

I’m unsure how to approach this. Omitting resources isn’t a good practice—it feels like a hack. From my perspective, the right approach would be to identify the cause of the issue and fix it. As a quick fix, it’s possible to remove the resources or leave a comment in the values and documentation. But again, that’s just a hack.

What’s your take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants