Fallback locale does not fork

[akolpakov]

In case if we use locale that does not presented. For example:

loadMessages({
  'en': {
    welcome: 'Hallo, heute ist der {date}',
  }
})

And we use GlobalizeProvider with localeFallback: "en"

When user is in locale sv for example, we get the following error:

[RNGlobalize] CLDR data for the selected language/locale has not been loaded!

The reason, that in the code we have:

react-native-globalize/src/globalize/index.ts

Line 49 in 3e3c63a

cfg.locale = (cfg.fallback && findFallbackLocale(cfg.locale)) as string;

It means if cfg.fallback is "en", we still try to findFallbackLocale for locale sv which does not exist

We need to change it to:

cfg.locale = (cfg.fallback && findFallbackLocale(cfg.fallback)) as string;

[joshswan]

As documented in the types and the docs, localeFallback and cfg.fallback are meant to be booleans currently, simply enabling or disabling the auto-fallback behavior (e.g. en-US -> en). Changing the implementation like this would break existing code and require a major version bump. I think a separate config prop that's opt-in would be a better solution.

[akolpakov]

I got you.

But how to avoid the case when user's locale does not exists in the loadMessages?

[joshswan]

Yeah I think this is a valid enhancement, just need to figure out the implementation details. Looking into implementing a new config prop defaultLocale as we speak. Will update shortly.

[joshswan]

Released v4.4.0. Setting defaultLocale="en" on GlobalizeProvider should now behave as described above (i.e. it won't throw in the event of an unknown locale and will instead use the en locale).