Fix wrong error for relative imports (#11)

joshuajaco · Oct 8, 2021 · 8b214e0 · 8b214e0
1 parent 048ad5d
commit 8b214e0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/no-relative-imports.js b/lib/rules/no-relative-imports.js
@@ -19,7 +19,11 @@ module.exports.meta = {
 module.exports.create = (context) =>
  getImport(context, ({ node, path, start, end, currentPackage }) => {
  packages.forEach(({ name, location }) => {
- if (name !== currentPackage.name && isSubPath(location, path)) {
+ if (
+ name !== path &&
+ name !== currentPackage.name &&
+ isSubPath(location, path)
+ ) {
  context.report({
  node,
  messageId: 'noRelativeImports',

diff --git a/tests/rules/no-relative-imports.js b/tests/rules/no-relative-imports.js
@@ -11,6 +11,10 @@ ruleTester.run('no-relative-imports', rule, {
  "import '@test/workspace';",
  "import '../some/relative/path';",
  'someFunction();',
+ {
+ filename: '/test/workspace/test.js',
+ code: "import 'root';",
+ },
  {
  filename: '/test/workspace/test.js',
  code: "import '../workspace';",

diff --git a/tests/setup.js b/tests/setup.js
@@ -40,4 +40,8 @@ mock('@joshuajaco/get-monorepo-packages', () => [
  name: '@test/scoped-workspace',
  },
  },
+ {
+ location: 'root',
+ package: { name: 'root' },
+ },
 ]);