Add support for lerna-based eslint runs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't cover https://github.com/joshuajaco/eslint-plugin-workspaces/pull/10/files#diff-5dfe38baf287dcf756a17c2dd63483781b53bf4b669e10efdd01e74bcd8e780aR28-R30 because this should catch json parse errors |
|
Thanks for this. About the coverage, couldn't we ignore the json error and let it crash? I think eslint won't run with an invalid package.json anyway. |
|
@joshuajaco I drop it. Thx for feedback |
|
Published in v0.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In our monorepository we use lerna for running eslint parallel
Like this:
In this case
process.cwd()return not repo-root path, but package path.In my solution I search repo-root by searching package.json with
workspacesproperty