Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSymbols Oanda lexical error #387

Closed
macray76 opened this issue Jun 28, 2023 · 3 comments
Closed

getSymbols Oanda lexical error #387

macray76 opened this issue Jun 28, 2023 · 3 comments
Assignees
@joshuaulrich
Labels
bug
Milestone
Release 0.4.24

Comments

@macray76
Copy link

When executing any getSymbols command to Oanda results in a json error rather than extracting the daily rate.

getSymbols("EUR/GBP", src="oanda", from="2023-06-26", to="2023-06-26", auto.assign=FALSE)

Result:

Error in getSymbols.oanda(Symbols = "EUR/GBP", env = <environment>, verbose = FALSE,  : 
  Unable to import “EUR/GBP”.
lexical error: invalid char in json text.
                                       <!DOCTYPE html> <html lang="en"
                     (right here) ------^
@jrwishart
Copy link

A URL for oanda.com is made and fed into jsonlite::fromJSON here

quantmod/R/getSymbols.R

Lines 1152 to 1163 in f60b99d

oanda.URL <- paste0("https://www.oanda.com/fx-for-business/",
"historical-rates/api/data/update/",
"?&source=OANDA&adjustment=0",
"&base_currency=", currency.pair[1],
"&start_date=", from,
"&end_date=", to,
"&period=daily",
"&price=mid",
"&view=table",
"&quote_currency_0=", currency.pair[2])
# Fetch data (jsonlite::fromJSON will handle connection)
tbl <- jsonlite::fromJSON(oanda.URL, simplifyVector = FALSE)
This is now rejected by fromJSON with

Error in parse_con(txt, bigint_as_char) : 
  lexical error: invalid char in json text.
                                       <!DOCTYPE html> <html lang="en"
                     (right here) ------^

I am guessing the structure of the oanda website has changed and an update to this code is required?

@QuinHsieh
Copy link

If I implement the following commend, such like getFX("USD/JPY") or getMetals(c("gold","XPD")), it responds some the errors that can not understand.

1688020510249
1688020542581

Could everyone solve these problems?

@JimboMahoney
Copy link

Also seeing this and suspect it's an issue with Oanda - looks like they have changed URL (as @jrwishart mentions) and/or changed their data access for some / most datasets to premium / pro

.·´¯(>▂<)´¯·.

@joshuaulrich joshuaulrich self-assigned this Jul 4, 2023
@joshuaulrich joshuaulrich mentioned this issue Jul 9, 2023
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jan 4, 2025
(finance/R-quantmod) Updated 0.4.22 to 0.4.26, NEWS.md not recent
68ff06d 
### Changes in 0.4.25 (2023-08-21)

1. Fix `getQuote.yahoo()` for API changes. Thanks to Ethan B. Smith for the
    report and patch! Also add error message for users in GDPR countries, since
    we cannot automatically consent to GDPR and the request fails without
    consent.
    [#392](joshuaulrich/quantmod#392)
    [#393](joshuaulrich/quantmod#393)
    [#395](joshuaulrich/quantmod#395)

1. Fix `getQuote.yahoo()` when the user only requested metrics that do not have
    have a value for 'regularMarketTime'. Set the value to NA in these cases
    so the output remains the same regardless of whether the endpoint returns
    a 'regularMarketTime' or not. Thanks to @mehdiMBH for the report!
    [#255](joshuaulrich/quantmod#255)

1. Add fields to `getQuote.yahoo()` that are returned when no fields are
    explicitly requested. Thanks to @Courvoisier13 for the report!
    [#335](joshuaulrich/quantmod#335)

1. Add intraday endpoint to `getSymbols.yahoo()`. Thanks to @kapsner for the
    report and patch! Also allow suppressing the warning if more than 7 days
    of data are requested (@eddelbuettel).
    [#351](joshuaulrich/quantmod#351)
    [#381](joshuaulrich/quantmod#381)
    [#399](joshuaulrich/quantmod#399)

1. Add warning if `getSymbols()` is called with tickers that are reserved words
    because accessing them requires back-quotes (e.g. ``NA``).
    [#401](joshuaulrich/quantmod#401)

1. Fix `allReturns()` when 'subset' is specified. Thanks to @Panagis1980 for
    the report!
    [#402](joshuaulrich/quantmod#402)

### Changes in 0.4.24 (2023-07-17)

1. Fix `getSymbols.oanda()` URL. Thanks to @macray76 for the report.
    [#387](joshuaulrich/quantmod#387)

### Changes in 0.4.23 (2023-06-14)

1. Fix `getQuote.yahoo()` error. Thanks to Ethan B. Smith for the report and
    patch!
    [#382](joshuaulrich/quantmod#382)
    [#383](joshuaulrich/quantmod#383)

1. Add `name` argument to `add_TA()`. Thanks to @SamoPP for the suggestion!
    [#377](joshuaulrich/quantmod#377)
    [#205](joshuaulrich/quantmod#205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaulrich joshuaulrich

Labels
bug
Projects
None yet
Milestone
Release 0.4.24
Development

No branches or pull requests
5 participants
@macray76 @joshuaulrich @jrwishart @JimboMahoney @QuinHsieh