-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
280 remove file io #281
Merged
joshuaulrich
merged 11 commits into
joshuaulrich:master
from
ethanbsmith:280_remove_file_io
Nov 3, 2019
Merged
280 remove file io #281
joshuaulrich
merged 11 commits into
joshuaulrich:master
from
ethanbsmith:280_remove_file_io
Nov 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bring fork up to date
This reverts commit 09dbb0e.
repalced all for download.file and curl_fetch_disk. left calls in loadSymbol.r alone
Hi @ethanbsmith, thanks for working on this PR! Is it ready for review? |
Yes.
…________________________________
From: Joshua Ulrich <notifications@github.com>
Sent: Saturday, October 26, 2019 5:52:25 AM
To: joshuaulrich/quantmod <quantmod@noreply.github.com>
Cc: Ethan Smith <ethan.smith@pobox.com>; Mention <mention@noreply.github.com>
Subject: Re: [joshuaulrich/quantmod] 280 remove file io (#281)
Hi @ethanbsmith<https://github.com/ethanbsmith>, thanks for working on this PR! Is it ready for review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#281?email_source=notifications&email_token=AF2ACB62STXTPOXA2324C4LQQQVPTA5CNFSM4JB6QN22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKGILA#issuecomment-546595884>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF2ACB7A6KVJGEBELPEZU4DQQQVPTANCNFSM4JB6QN2Q>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed disk i/o from critical path of functions that fetch data form the internet. these functions now operate entirely in memory
main drivers for this:
Fixes #280