Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 method issues #398

Closed
joshuaulrich opened this issue Mar 16, 2023 · 0 comments
Closed

S3 method issues #398

joshuaulrich opened this issue Mar 16, 2023 · 0 comments
Milestone

Comments

@joshuaulrich
Copy link
Owner

joshuaulrich commented Mar 16, 2023

Description

With R-devel (83995-ish) R CMD check and _R_CHECK_S3_METHODS_SHOW_POSSIBLE_ISSUES_=true shows the following:

Package xts:
Mismatches for apparent methods not registered:
str:
  function(object, ...)
str.replot_xts:
  function(x, ...)

time:
  function(x, ...)
time.frequency:
  function(x)

as.POSIXct:
  function(x, tz, ...)
as.POSIXct.tis:
  function(x, offset, tz, ...)

Apparent methods for exported generics not registered:
  as.xts.tis tformat.default

Need to register S3 methods for:

  • str.replot_xts()
  • as.POSIXct.tis()
  • as.xts.tis()
  • tformat.default()

And rename time.frequency() to time_frequency() (or delete because it's not used).

joshuaulrich added a commit that referenced this issue Mar 19, 2023
With R-devel (83995-ish) `R CMD check` notes these S3 methods are not
registered. It also notes that the signatures for as.POSIXct.tis() and
str.replot_xts() do not match the respective generics.

It also thinks time.frequency() is a S3 method because time() is a
generic. The function isn't exported, so renaming won't break any
external code.

See #398.
@joshuaulrich joshuaulrich added this to the 0.13.1 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant