-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 method issues #398
Milestone
Comments
joshuaulrich
added a commit
that referenced
this issue
Mar 19, 2023
With R-devel (83995-ish) `R CMD check` notes these S3 methods are not registered. It also notes that the signatures for as.POSIXct.tis() and str.replot_xts() do not match the respective generics. It also thinks time.frequency() is a S3 method because time() is a generic. The function isn't exported, so renaming won't break any external code. See #398.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
With R-devel (83995-ish)
R CMD check
and_R_CHECK_S3_METHODS_SHOW_POSSIBLE_ISSUES_=true
shows the following:Need to register S3 methods for:
str.replot_xts()
as.POSIXct.tis()
as.xts.tis()
tformat.default()
And rename
time.frequency()
totime_frequency()
(or delete because it's not used).The text was updated successfully, but these errors were encountered: