-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine axTicksByTime and axTicksByTime2 #74
Labels
Milestone
Comments
Consider how |
joshuaulrich
pushed a commit
that referenced
this issue
Jun 12, 2018
axTicksByTime() has long been exported from xts, so its behavior is maintained as closely as possible. axTicksByTime2() came from the port of quantmod::chart_Series() to plot.xts(). Add millisecond and microsecond tick.opts, both with tick.k.opts of 1. Also avoid calls to strsplit() to get the arguments for the endpoints() call, and when calculating 'cl' and 'ck'. Move tick.k.opts definition closer to its use. Make sure 'lt' is less than or equal to the number of observations. Fixes #74.
joshuaulrich
added a commit
that referenced
this issue
Jun 12, 2018
axTicksByTime() has long been exported from xts, so its behavior is maintained as closely as possible. axTicksByTime2() came from the port of quantmod::chart_Series() to plot.xts(). Add millisecond and microsecond tick.opts, both with tick.k.opts of 1. Also avoid calls to strsplit() to get the arguments for the endpoints() call, and when calculating 'cl' and 'ck'. Move tick.k.opts definition closer to its use. Make sure 'lt' is less than or equal to the number of observations. Fixes #74.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xts exports
axTicksByTime
, but the newplot.xts
usesaxTicksByTime2
that came from the port ofchart_Series
toplot.xts
. For simplicity's sake, these two functions should be combined... once we understand their differences.We need to ensure not to break anything that currently uses
axTicksByTime
(e.g. many of the charting functions in PerformanceAnalytics).The text was updated successfully, but these errors were encountered: