Fix multi-column filling when first column all NA #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The firstNonNA check only checks the first column for a 2-dimensional SEXP. Therefore if the first column is NA, the function returns without examining any other columns. Fix by removing this check. Fixes joshuaulrich#233
|
This will conflict with the fix to #234 since both checks were added to the end of the file. I can rebase the other once the first is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firstNonNA check only checks the first column for a 2-dimensional
SEXP. Therefore if the first column is NA, the function returns
without examining any other columns.
Fix by removing this check.
Fixes #233