This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
CI for coverage report setup #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jest already uses Istanbul, I don't think it's necessary if you run jest with I might be mistaken, but see: istanbuljs/nyc#524 |
Haroenv
reviewed
Sep 6, 2018
AWolf81
changed the title
joshwcomeau
approved these changes
Sep 7, 2018
| behavior: default | ||
| require_changes: true # if true: only post the comment if coverage changes | ||
| require_base: no # [yes :: must have a base report to post] | ||
| require_head: yes # [yes :: must have a head report to post] |
There was a problem hiding this comment.
If I understand this correctly, it will show a comment if:
- The branch being merged in has changed the coverage in some way
- The branch being merged in has a codecov report available
- Whether or not the merge-target (usually
master) has a codecov report
I think require_changes should be false - I like the idea of having a little indication of "Coverage was not affected by this PR. I don't have strong feelings though :) happy to leave it as-is for now and update later if we feel the need
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#214
Summary:
First coverage report for the branch is available here.
Codecov report can be found here.
Danger.js: I think we can add it later. I've looked a bit into it but I stopped at creation of aguppy-botGithub account. It would require to create a new account with an e-mail address and that feels strange.OK, I think this is ready now. The codecov comment is probably missing in this PR because codecov is expecting the
codecov.ymlin master.Info from the docs:
The following command helps to validate the config file:
curl --data-binary @codecov.yml https://codecov.io/validate