Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Test AppSettingsModal component #371

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Conversation

AWolf81
Copy link
Collaborator

@AWolf81 AWolf81 commented Mar 27, 2019

Related Issue:
#309

Summary:
Added tests for AppSettingsModal

  • Updating activeField
  • Saving newSettings
  • Dialog test if path does't exists
  • Snapshot for rendering

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #371 into master will increase coverage by 3.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   52.35%   55.78%   +3.42%     
==========================================
  Files         158      158              
  Lines        3335     3304      -31     
  Branches      458      458              
==========================================
+ Hits         1746     1843      +97     
+ Misses       1362     1247     -115     
+ Partials      227      214      -13
Impacted Files Coverage Δ
...rc/components/AppSettingsModal/AppSettingsModal.js 96% <ø> (+96%) ⬆️
src/utils.js 39.43% <0%> (+5.63%) ⬆️
src/components/TextInput/TextInput.js 100% <0%> (+10%) ⬆️
src/components/FormField/FormField.js 100% <0%> (+12.5%) ⬆️
...nents/ProjectTypeSelection/ProjectTypeSelection.js 72.72% <0%> (+27.27%) ⬆️
src/components/Heading/Heading.js 75% <0%> (+33.33%) ⬆️
src/components/DirectoryPicker/DirectoryPicker.js 46.15% <0%> (+46.15%) ⬆️
src/components/PixelShifter/PixelShifter.js 100% <0%> (+50%) ⬆️
src/components/ModalHeader/ModalHeader.js 100% <0%> (+57.14%) ⬆️
src/components/ScrollDisabler/ScrollDisabler.js 59.09% <0%> (+59.09%) ⬆️
... and 3 more

Copy link
Collaborator

@superhawk610 superhawk610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Getting that coverage closer to 100% every day.

@superhawk610 superhawk610 merged commit 7a1ab5e into master Mar 28, 2019
@superhawk610 superhawk610 deleted the test-app-settings-modal branch March 28, 2019 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants