-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
findDOMNode was called on an unmounted component #66
Comments
Thanks for the report @vcarel - I'll have a go at reproducing, I think you're on the right track about the cause. |
Yup, found the bug as well, will push a fix asap |
eek
pushed a commit
to eek/react-visibility-sensor
that referenced
this issue
Mar 8, 2017
Same issues, May I know when the fix is going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're using react-visibilty-sensor to animate pictures on our home page, and we use https://sentry.io to monitor errors on client side.
We've got multiple reports on the following issue: "Invariant Violation: findDOMNode was called on an unmounted component"
This happens in visibility-sensor.js, there:
(on Chrome mobile 56.0.2924)
I can't reproduce on my computer, but looks related to the tabs "Je suis propriétaire / Je suis acquéreur".
What I understand from your code is that at the end there's no real issue, because if you can't find the node you do nothing. But that warning is a bit annoying.
I presume the issue comes from a last
check()
call by "debounceCheck", because you don't clear the setTimeout l.21 onstopWatching
The text was updated successfully, but these errors were encountered: