Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix & refactor: allow defining a custom cookie vault #65

Merged
merged 5 commits into from
May 4, 2022
Merged

fix & refactor: allow defining a custom cookie vault #65

merged 5 commits into from
May 4, 2022

Conversation

sehnryr
Copy link
Collaborator

@sehnryr sehnryr commented Apr 29, 2022

Proposed changes

Allow defining a custom cookie vault with an optional HiveCipher as the encryption cipher when initializing Requests with init method.

cc @aramperes

Closes #62.

Type of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • My code follows the Dart coding convention
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary documentation (if appropriate)

Further comments

Replaces #63 since its author did not allow edits by the maintainers.

@sehnryr sehnryr changed the title Allow defining a custom cookie vault fix & refactor: allow defining a custom cookie vault May 4, 2022
@sehnryr sehnryr merged commit 83b7731 into jossef:master May 4, 2022
@sehnryr sehnryr deleted the 62-set-cookie-vault branch May 4, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing cipher to Hive store
2 participants