Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle double quotes lodash imports #4

Merged
merged 3 commits into from
May 22, 2022
Merged

Conversation

omeraplak
Copy link
Contributor

@omeraplak omeraplak commented Mar 1, 2022

I've found this solution from https://github.com/mikeduminy/esbuild-plugin-ramda/blob/main/index.js#L18. Thank you @mikeduminy !

import { unionWith, reverse, differenceWith } from "lodash";

import { unionWith, reverse, differenceWith } from 'lodash';

@josteph josteph changed the title Handle double quotes lodash imports feat: handle double quotes lodash imports May 22, 2022
@josteph josteph merged commit ee59f86 into josteph:main May 22, 2022
@josteph
Copy link
Owner

josteph commented May 22, 2022

Thanks @omeraplak 🙏

github-actions bot pushed a commit to digitalmaas/esbuild-plugin-lodash that referenced this pull request Jun 5, 2024
## 1.0.0 (2024-06-05)

### Features

* add initial plugin ([9ed8499](9ed8499))
* Add outLodashPackage feature to allow for lodash-es, fix .cjs and .mjs files. ([josteph#2](https://github.com/digitalmaas/esbuild-plugin-lodash/issues/2)) ([f604fee](f604fee))
* fork `eslint-plugin-lodash`, add extension support ([7cf24d6](7cf24d6))
* handle double quotes lodash imports ([josteph#4](https://github.com/digitalmaas/esbuild-plugin-lodash/issues/4)) ([ee59f86](ee59f86)), closes [/github.com/mikeduminy/esbuild-plugin-ramda/blob/main/index.js#L18](https://github.com/digitalmaas//github.com/mikeduminy/esbuild-plugin-ramda/blob/main/index.js/issues/L18)

### Bug Fixes

* import lodash/last bug ([#1](#1)) ([e91dff2](e91dff2))
* loader & function type ([e710105](e710105))
* remove namespace option, use esbuild default namespace ([489d8b3](489d8b3))
* rename plugins ([da4f0e4](da4f0e4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants