Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.StorageCache to add vers…
Browse files Browse the repository at this point in the history 
…ion stable/2020-10-01 (Azure#11407)

* Init the next version so diffs can work better.

* Updates readme

* Updates API version in new specs and examples

* Updates to StorageTargetProperties and added examples of cmk, mtu

Add 202 to the storage cache and storage target create/update and update examples

Fix ST no junction example's 202 response.

add properties for nfs extended groups

fix issues with extended groups properties found with autorest

add properties and objects for Active Directory username download

undo unintended change

changes from comments in pull request

AccessPolicy support.

Example fixes for Access Policies.

Fix attribute names to match latest RP.

update to credential properties for LDAP and Active Directory

marking password properties with x-ms-secret tag

minor changes on extended groups and add examples

Added blob NFS and some other validation fixes.

Update required property for domainName from dnsName

Updated blobNfs examples and some kpi fixes.

Correct validation errors in examples.

Added systemdata to resources.

Remove x-ms-secret in keyvault reference due to linter error and common types not using it.

Remove blobNfs from this version.

Remove blobNfs from spec file.

Remove x-ms-secret due to linter errors.

Fix certificate spelling.

Updating prettier and spell check errors.

Used prettier on main spec file.

Readded x-ms-secret that open api hub failed on but the PR pipeline allows.

* Add prettier fix after rebase

* Remove 202 bodies and add systemData to examples.

* Update spec with prettier.

* Address comments on spec for descriptions, readmes, and extendedGroupsEnabled.

* Updating to address addition ldap and pattern comments.

* Update version tag to include 01

* Restore changes that would be considered breaking changes matching 2020-03-01

* Address a few other comments.

* Update netbios field names and some descriptions.

* Fix s360 for missing debugInfo operation.

* Fix credscan error in example file.

* Update required fields, new validator failure on debugInfo return codes, and bindPassword example value.

* Update debug info example with new return codes.

* Update other credscan password errors.
  • Loading branch information
@brpanask
brpanask authored and josuh committed Jan 6, 2021
1 parent 24b7ee6 commit bfc33ba
Show file tree
Hide file tree
Showing 29 changed files with 4,421 additions and 8 deletions.
3 changes: 3 additions & 0 deletions custom-words.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,7 @@ paramref
PARAVIRTUAL
partnertopic
Passthrough
passwd
patternanyentities
patternrule
patternrules
Expand Down Expand Up @@ -1700,6 +1701,7 @@ subfolders
subinquireditemcount
sublist
sublists
submount
subnames
subnet
subnet's
Expand All @@ -1723,6 +1725,7 @@ subword
subwords
sudoer
suggesters
suid
Superfresh
superset
supportedimages
Expand Down
19 changes: 19 additions & 0 deletions ...resource-manager/Microsoft.StorageCache/stable/2020-10-01/examples/AscOperations_Get.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"location": "westus",
"operationId": "testoperationid",
"api-version": "2020-10-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/id/locations/westus/ascOperations/testoperationid",
"name": "testoperationid",
"startTime": "2020-10-01T13:13:13.933Z",
"endTime": "2020-10-01T16:13:13.933Z",
"status": "Succeeded"
}
}
}
}
255 changes: 255 additions & 0 deletions ...urce-manager/Microsoft.StorageCache/stable/2020-10-01/examples/Caches_CreateOrUpdate.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,255 @@
{
"parameters": {
"resourceGroupName": "scgroup",
"cacheName": "sc1",
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"api-version": "2020-10-01",
"cache": {
"tags": {
"Dept": "ContosoAds"
},
"location": "westus",
"properties": {
"cacheSizeGB": 3072,
"subnet": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.Network/virtualNetworks/scvnet/subnets/sub1",
"encryptionSettings": {
"keyEncryptionKey": {
"keyUrl": "https://keyvault-cmk.vault.azure.net/keys/key2047/test",
"sourceVault": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.KeyVault/vaults/keyvault-cmk"
}
}
},
"directoryServicesSettings": {
"activeDirectory": {
"primaryDnsIpAddress": "192.0.2.10",
"secondaryDnsIpAddress": "192.0.2.11",
"cacheNetBiosName": "contosoSmb",
"domainName": "contosoAd.contoso.local",
"domainNetBiosName": "contosoAd",
"credentials": {
"username": "consotoAdmin",
"password": "<password>"
}
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"usernameSource": "LDAP",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"credentials": {
"bindDn": "cn=ldapadmin,dc=contosoad,dc=contoso,dc=local",
"bindPassword": "<bindPassword>"
}
}
},
"securitySettings": {
"accessPolicies": [
{
"name": "default",
"accessRules": [
{
"scope": "default",
"access": "rw",
"suid": false,
"submountAccess": true,
"rootSquash": false
}
]
}
]
}
},
"sku": {
"name": "Standard_2G"
}
}
},
"responses": {
"202": {},
"201": {
"body": {
"tags": {
"Dept": "ContosoAds"
},
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.StorageCache/caches/sc1",
"location": "westus",
"name": "sc1",
"type": "Microsoft.StorageCache/Cache",
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"cacheSizeGB": 3072,
"health": {
"state": "Transitioning",
"statusDescription": "Cache is being created."
},
"mountAddresses": [
"192.168.1.1",
"192.168.1.2"
],
"provisioningState": "Succeeded",
"subnet": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.Network/virtualNetworks/scvnet/subnets/sub1",
"upgradeStatus": {
"currentFirmwareVersion": "5.3.23",
"firmwareUpdateStatus": "available",
"firmwareUpdateDeadline": "2019-04-21T18:25:43.511Z",
"lastFirmwareUpdate": "2019-01-21T18:25:43.511Z",
"pendingFirmwareVersion": "5.3.24"
},
"networkSettings": {
"mtu": 1500
},
"securitySettings": {
"accessPolicies": [
{
"name": "default",
"accessRules": [
{
"scope": "default",
"access": "rw",
"suid": false,
"submountAccess": true,
"rootSquash": false
}
]
}
]
},
"encryptionSettings": {
"keyEncryptionKey": {
"keyUrl": "https://keyvault-cmk.vault.azure.net/keys/key2048/test",
"sourceVault": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.KeyVault/vaults/keyvault-cmk"
}
}
},
"directoryServicesSettings": {
"activeDirectory": {
"primaryDnsIpAddress": "192.0.2.10",
"secondaryDnsIpAddress": "192.0.2.11",
"domainName": "contosoAd.contoso.local",
"domainNetBiosName": "contosoAd",
"cacheNetBiosName": "contosoSmb",
"domainJoined": "No"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
"caCertificateURI": "",
"usernameDownloaded": "No"
}
}
},
"sku": {
"name": "Standard_2G"
}
}
},
"200": {
"body": {
"tags": {
"Dept": "ContosoAds"
},
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.StorageCache/caches/sc1",
"location": "westus",
"name": "sc1",
"type": "Microsoft.StorageCache/Cache",
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"cacheSizeGB": 3072,
"health": {
"state": "Transitioning",
"statusDescription": "Cache is being created."
},
"mountAddresses": [
"192.168.1.1",
"192.168.1.2"
],
"provisioningState": "Updating",
"subnet": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.Network/virtualNetworks/scvnet/subnets/sub1",
"upgradeStatus": {
"currentFirmwareVersion": "V5.1.12",
"firmwareUpdateStatus": "available",
"firmwareUpdateDeadline": "2019-04-21T18:25:43.511Z",
"lastFirmwareUpdate": "2019-01-21T18:25:43.511Z",
"pendingFirmwareVersion": "V5.1.15"
},
"networkSettings": {
"mtu": 1500
},
"securitySettings": {
"accessPolicies": [
{
"name": "default",
"accessRules": [
{
"scope": "default",
"access": "rw",
"suid": false,
"submountAccess": true,
"rootSquash": false
}
]
}
]
},
"encryptionSettings": {
"keyEncryptionKey": {
"keyUrl": "https://keyvault-cmk.vault.azure.net/keys/key2048/test",
"sourceVault": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.KeyVault/vaults/keyvault-cmk"
}
}
},
"directoryServicesSettings": {
"activeDirectory": {
"primaryDnsIpAddress": "192.0.2.10",
"secondaryDnsIpAddress": "192.0.2.11",
"domainName": "contosoAd.contoso.local",
"domainNetBiosName": "contosoAd",
"cacheNetBiosName": "contosoSmb",
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
"caCertificateURI": "",
"usernameDownloaded": "Yes"
}
}
},
"sku": {
"name": "Standard_2G"
}
}
}
}
}
Loading

0 comments on commit bfc33ba

Please sign in to comment.