-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Improvements #13
Merged
ohcibi
merged 9 commits into
joukevandermaas:master
from
NullVoxPopuli:minor-improvementns
May 12, 2021
Merged
Minor Improvements #13
ohcibi
merged 9 commits into
joukevandermaas:master
from
NullVoxPopuli:minor-improvementns
May 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add |
Eventually we will be able to remove Ember 2.0 cruft. |
… if someone wishes (not all themes support the full list of highlight keys
let added! |
2abed32
to
43abf03
Compare
43abf03
to
26e6035
Compare
Prior to this change, this used a lot of nested groups. This change removes the grouping and focuses on the allowed characters/sequences expected in a HBS component
Prior to this change, strings didn't contain hbsMustache syntax This change adds strings to the containedin clause. It does not include the hbsMustacheBlock as that is not a thing inside strings.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New helpers
New modifiers
New features
Color / Identifier Tweaks
Preview
Before
After