Alexa: allows use of env. variables instead of cli_config for ask-cli #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Jovo CLI always added a profile to each ask cli command even if the user didn't parse one. That resulted in the ask-cli never checking for any kind of env variables. Instead it always checked for the 'default' profiles config. \n The ask-cli handles the parsing of the ask profile as well. It's either the parsed askProfile using '-p' > the access/refresh token set as env variables > the ASK_DEFAULT_PROFILE env variable> 'default'. Since Jovo parsed an askProfile no matter what, the other 3 possibilities were never executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Jovo CLI always added a profile to each ask cli command even if the user didn't parse one. That resulted in the ask-cli never checking for any kind of env variables. Instead, it always checked for the 'default' profiles config.
The ASK-CLI determines the correct profile the following way: it's either the parsed askProfile using '-p' > the access/refresh token set as env variables > the ASK_DEFAULT_PROFILE env variable > 'default' profile. Since Jovo parsed an askProfile no matter what, the other 3 possibilities were never executed
ASK-CLI determining the correct profile: https://github.com/alexa/ask-cli/blob/develop/lib/utils/profile-helper.js#L17
Proposed changes
Types of changes
Checklist