🚚 Abstract JovoCli class, pass instance to plugins #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, all plugins had access to
JovoCli.getInstance()
fromcli-core
, which only worked in a dev environment, as the instance is not stateless, and therefore having multiplecli-core
would break functionality. This PR fixes this by passing the instance down to the plugins, where it is accessible withthis.$cli
.Types of changes
Checklist