Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚑 Adjust webhook #272

Merged
merged 3 commits into from
Dec 7, 2021
Merged

🚑 Adjust webhook #272

merged 3 commits into from
Dec 7, 2021

Conversation

rubenaeg
Copy link
Contributor

@rubenaeg rubenaeg commented Dec 7, 2021

Proposed changes

With the v4 launch, we converted the webhook back to its original format, but missed adjusting it here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@rubenaeg rubenaeg merged commit 1887919 into v4/dev Dec 7, 2021
@rubenaeg rubenaeg deleted the v4/fix/webhook branch December 7, 2021 14:39
@vpego
Copy link

vpego commented Dec 9, 2021

thank guys for always paying attention to the community feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

@aswetlow aswetlow aswetlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rubenaeg @vpego @jankoenig @aswetlow