Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invocation name requirements #48

Merged
merged 8 commits into from
Jul 16, 2018

Conversation

KristaTheCoder
Copy link
Contributor

@KristaTheCoder KristaTheCoder commented Jul 13, 2018

Proposed changes

Added validation for Amazon Alexa Invocation Name requirements

Previous:
-- Checked Undefined or Empty Invocation name

Added:
-- Checks for length requirement
-- Checks for lower case letter requirement
-- Checks no numbers requirement

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

(I'm not sure how to write tests for this feature & latest commit doesn't show any errors as far as I know)

@jankoenig
Copy link
Member

Thanks a lot @KristaTheCoder 👍 We'll take a look

@aswetlow
Copy link
Member

Thanks @KristaTheCoder !

@aswetlow aswetlow merged commit cc7d6ab into jovotech:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants