Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict valgrind test runs to most recent gcc/clang version only #66

Closed
jow- opened this issue Mar 31, 2022 · 3 comments · Fixed by #75
Closed

Restrict valgrind test runs to most recent gcc/clang version only #66

jow- opened this issue Mar 31, 2022 · 3 comments · Fixed by #75

Comments

@jow-
Copy link
Owner

jow- commented Mar 31, 2022

With the proliferation of test cases, CI runs tend to become rather long since we run all tests under valgrind using multiple gcc and Clang versions each. I think we should tests under valgrind only for the most recent gcc and Clang versions covered and run the testsuite without valgrind for older versions.
@jow-
Copy link
Owner Author

jow- commented Mar 31, 2022

@ynezz

@jow- jow- changed the title Restrict valgrind test runs to most recent gcc/clang verison only Restrict valgrind test runs to most recent gcc/clang version only Mar 31, 2022
@ynezz
Copy link
Contributor

ynezz commented Mar 31, 2022 •
edited
Loading

@jow- So this CI job speedup change should only affect CI behavior during pull requests and you would like to keep the current more time consuming testing matrix running only when the changes hit the main branch (push event)?

@jow-
Copy link
Owner Author

jow- commented Mar 31, 2022

Good question, but I think it makes sense to only speed up PR triggered CI runs and do more thorough runs on main branch merges, yes.

ynezz added a commit to ynezz/openwrt-ucode that referenced this issue May 8, 2022
@ynezz
ci: make jobs faster during pull request testing
08e9023 
With the proliferation of test cases, CI runs tend to become rather long
since we run all tests under valgrind using multiple gcc and Clang
versions each.

In order to speedup the jobs, we tests pull requests under valgrind only
for the most recent GCC and Clang versions and run all tests when the
code hits the master branch.

Closes jow-#66
Signed-off-by: Petr Štetiar <ynezz@true.cz>
ynezz added a commit to ynezz/openwrt-ucode that referenced this issue May 8, 2022
@ynezz
ci: make jobs faster during pull request testing
5a5487e 
With the proliferation of test cases, CI runs tend to become rather long
since we run all tests under valgrind using multiple gcc and Clang
versions each.

In order to speedup the jobs, we tests pull requests under valgrind only
for the most recent GCC and Clang versions and run all tests when the
code hits the master branch.

Closes jow-#66
Signed-off-by: Petr Štetiar <ynezz@true.cz>
ynezz added a commit to ynezz/openwrt-ucode that referenced this issue May 8, 2022
@ynezz
ci: make jobs faster during pull request testing
f2858c7 
With the proliferation of test cases, CI runs tend to become rather long
since we run all tests under valgrind using multiple gcc and Clang
versions each.

In order to speedup the jobs, we tests pull requests under valgrind only
for the most recent GCC and Clang versions and run all tests when the
code hits the master branch.

Closes jow-#66
Signed-off-by: Petr Štetiar <ynezz@true.cz>
ynezz added a commit to ynezz/openwrt-ucode that referenced this issue May 8, 2022
@ynezz
ci: make jobs faster during pull request testing
cdf82e5 
With the proliferation of test cases, CI runs tend to become rather long
since we run all tests under valgrind using multiple gcc and Clang
versions each.

In order to speedup the jobs, we tests pull requests under valgrind only
for the most recent GCC and Clang versions and run all tests when the
code hits the master branch.

Closes jow-#66
Signed-off-by: Petr Štetiar <ynezz@true.cz>
ynezz added a commit to ynezz/openwrt-ucode that referenced this issue May 9, 2022
@ynezz
ci: make jobs faster during pull request testing
559029e 
With the proliferation of test cases, CI runs tend to become rather long
since we run all tests under valgrind using multiple gcc and Clang
versions each.

In order to speedup the jobs, we tests pull requests under the most
recent Clang versions and run all tests when the code hits the master
branch.

Closes jow-#66
Signed-off-by: Petr Štetiar <ynezz@true.cz>
@ynezz ynezz mentioned this issue May 9, 2022
Merged
@jow- jow- closed this as completed in #75 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: make jobs faster during pull request testing ynezz/openwrt-ucode
2 participants
@ynezz @jow-