Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: rework uc_index() implementation #77

Merged
merged 1 commit into from
May 31, 2022
Merged

lib: rework uc_index() implementation #77

merged 1 commit into from
May 31, 2022

Conversation

jow-
Copy link
Owner

@jow- jow- commented May 30, 2022

  • Fix segfault on passing string haystack with non-string needle argument
  • Perform strict equality tests against array haystacks
  • Make string searches binary safe
  • Improve left index string search performance
  • Improve right index array search performance
  • Add missing test coverage for index() and rindex()

Signed-off-by: Jo-Philipp Wich jo@mein.io

 - Fix segfault on passing string haystack with non-string needle argument
 - Perform strict equality tests against array haystacks
 - Make string searches binary safe
 - Improve left index string search performance
 - Improve right index array search performance
 - Add missing test coverage for index() and rindex()

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@jow- jow- force-pushed the lib-fix-index branch from b97cc6a to da3f089 Compare May 30, 2022 14:02
@jow- jow- merged commit ae62d72 into master May 31, 2022
@jow- jow- deleted the lib-fix-index branch August 6, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant