Fix the tests #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipobscure
commented
Jan 9, 2024
| try { | ||
| ({ stderr } = spawnSyncAndExitWithoutError('signtool', [ 'sign', '/fd', 'SHA256', targetExecutable ], {})); | ||
| ({ child, stderr } = spawnSyncAndExitWithoutError('signtool', [ 'sign', '/fd', 'SHA256', targetExecutable ], { status: undefined })); |
There was a problem hiding this comment.
This wasn't working because it would have status === 1 when it fails because of missing certificates. Which means it throws and that leaves stderr not set.
So in order to catch this issue, you have to ignore the status and check it here.
| certificatesFound = true; | ||
| } catch (err) { | ||
| if (!/SignTool Error: No certificates were found that met all the given criteria/.test(stderr)) { | ||
| throw err; | ||
| } | ||
| } | ||
| if (certificatesFound) { | ||
| spawnSyncAndExitWithoutError('signtool', 'verify', '/pa', 'SHA256', targetExecutable, {}); | ||
| spawnSyncAndExitWithoutError('signtool', [ 'verify', '/pa', 'SHA256', targetExecutable ], {}); |
There was a problem hiding this comment.
The args need to be passed in as an array. This was just never used probably (due to lack of certs?)
When it's a short string, print it inline, otherwise print it from a separate line. Also add the missing line breaks finally.
joyeecheung
force-pushed
the
sea-assets
branch
2 times, most recently
from
970f089
to
6bde66f
Compare
With this patch:
Users can now include assets by adding a key-path dictionary
to the configuration as the `assets` field. At build time, Node.js
would read the assets from the specified paths and bundle them into
the preparation blob. In the generated executable, users can retrieve
the assets using the `sea.getAsset()` and `sea.getAssetAsBlob()` API.
```json
{
"main": "/path/to/bundled/script.js",
"output": "/path/to/write/the/generated/blob.blob",
"assets": {
"a.jpg": "/path/to/a.jpg",
"b.txt": "/path/to/b.txt"
}
}
```
The single-executable application can access the assets as follows:
```cjs
const { getAsset } = require('node:sea');
// Returns a copy of the data in an ArrayBuffer
const image = getAsset('a.jpg');
// Returns a string decoded from the asset as UTF8.
const text = getAsset('b.txt', 'utf8');
// Returns a Blob containing the asset.
const blob = getAssetAsBlob('a.jpg');
```
Drive-by: update the documentation to include a section dedicated
to the injected main script and refer to it as "injected main
script" instead of "injected module" because it's a script, not
a module.
joyeecheung
force-pushed
the
sea-assets
branch
from
6bde66f
to
e1a56ff
Compare
This patch adds support for `sea.getRawAsset()` which is similar to `sea.getAsset()` but returns the raw asset in an array buffer without copying. Users should avoid writing to the returned array buffer. If the injected section is not marked as writable or not aligned, writing to the raw asset is likely to result in a crash.
joyeecheung
force-pushed
the
sea-assets
branch
from
e1a56ff
to
e12780f
Compare
joyeecheung
force-pushed
the
sea-assets
branch
from
e12780f
to
e58bdbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is slightly too complicated for using the suggestion features. Here is what's going on. Let me know in what way you want this.