This repository has been archived by the owner on May 4, 2018. It is now read-only.
unix: sanity-check fds before closing #943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,6 @@ | |||
|
|
|||
|
|
|||
| static void close_cb(uv_handle_t* handle) { | |||
| printf("close_cb\n"); | |||
There was a problem hiding this comment.
This was one of those bugs: calling printf() after fd 1 is closed.
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC from @piscisaureus and @saghul.
The idea is to catch a pretty common type of error that we have in node.js, namely closing stdio file descriptors.
It also ties in with nodejs/node-v0.x-archive#6271 where libuv triggers a Linux kernel bug that results in a busy loop.