This repository has been archived by the owner on May 4, 2018. It is now read-only.
fsevents: fix clever rescheduling #946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added test. |
| TEST_IMPL(fs_event_start_and_close) { | ||
| uv_loop_t* loop; | ||
| static uv_fs_event_t fs_event1; | ||
| static uv_fs_event_t fs_event2; |
There're could be a situation, where one fsevents handle gets created and another one is destroyed simultaneously. In such cases `fsevent_need_reschedule` will be set to 1 twice and reset only once, leaving handle destructor hanging in uv_sem_wait().
|
Fixed all nits, and improved patch to keep clever hack working. |
| if (!state->fsevent_need_reschedule) | ||
| return; | ||
| uv_mutex_lock(&state->fsevent_mutex); | ||
| if (state->fsevent_need_reschedule == 0) { |
There was a problem hiding this comment.
My comment about fsevent_need_reschedule still stands. It doesn't need to be volatile anymore, right?
|
One comment but otherwise LGTM. |
|
Landed in master in 429bb80. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're could be a situation, where one fsevents handle gets created
and another one is destroyed simultaneously. In such cases
fsevent_need_reschedulewill be set to 1 twice and reset only once,leaving handle destructor hanging in uv_sem_wait().
se nodejs/node-v0.x-archive#6296
/cc @bnoordhuis