Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Natives' Syntax-Issues & Implementation Laziness. #1774

Closed
19h opened this issue Sep 26, 2011 · 1 comment
Closed

Natives' Syntax-Issues & Implementation Laziness. #1774

19h opened this issue Sep 26, 2011 · 1 comment

Comments

@19h
Copy link

19h commented Sep 26, 2011

Nearly all of the native-libraries (like fs.js, http2.js, et al.) have syntax issues like redeclaration of variables, non/null-returning functions.

This is not a huge problem - nevertheless, those syntax-issues break node at the actual state when called with --harmony_typeof --harmony_weakmaps --harmony_block_scoping.

Example, node with given arguments at the actual state:

fs.js:415
var callback = (typeof(callback_) == 'function' ? callback_ : null);
^^^^^^^^

node.js:208
throw e; // process.nextTick error, or 'error' event on first tick
^
SyntaxError: Variable 'callback' has already been declared
at NativeModule.compile (node.js:522:14)
at Function.require (node.js:488:18)
at Function._findPath (module.js:152:25)
at Function._resolveFilename (module.js:325:25)
at Function._load (module.js:272:25)
at Array. (module.js:463:10)
at EventEmitter._tickCallback (node.js:200:26)

Cheers,
Kenan.

@bnoordhuis
Copy link
Member

We accepts patches for minor bugs like that (for major bugs too, of course), preferably multiple small ones - say one per module - instead of a single big patch. They should be written against the current master and should not break any tests that aren't already broken.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants