This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Simple fixes for issue #1774 related to fs.js #1837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k_scoping v8 option
|
LGTM. Can you sign the CLA? |
|
The CLA has been signed, merging. |
|
@talltyler - Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1774 was closed but never fixed, it was just small changes to fs.js, mostly related to callbacks being defined more than once. Some of this code could be cleaner but I tried not to make to many changes.
I've taken care of these issues and tested with the v8 option --harmony_block_scoping
Maybe unrelated but --harmony-proxies works fine with out these changes.