Update Logger.cpp #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not lose the log :)
fortrue
reviewed
Oct 13, 2018
| } else { | ||
| return nullptr; |
There was a problem hiding this comment.
The only condtion arrive here is mStop==true, so we should abandon this log then quit asap
There was a problem hiding this comment.
The current worker thread may also be woken up when other worker threads call the Logger::gInst::put method. Because two queues share the same condition variable.
There was a problem hiding this comment.
I think that two queues should each have their own locks and condition variables instead of sharing the same lock and the same condition variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not lose the log :)