Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded feature declarations #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshuawarner32
Copy link

This allows this crate to compile on stable rust, 1.48. Previously, I was seeing these errors:

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /home/joshw/.cargo/registry/src/github.com-1ecc6299db9ec823/doh-dns-0.2.0/src/lib.rs:59:1
   |
59 | #![feature(proc_macro_hygiene)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /home/joshw/.cargo/registry/src/github.com-1ecc6299db9ec823/doh-dns-0.2.0/src/lib.rs:60:1
   |
60 | #![feature(stmt_expr_attributes)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It's unclear to me why the code originally required these features? If they were stabilized I would expect a different error, about the feature decl not beeing needed.

@joshuawarner32
Copy link
Author

For reference, these are the tracking issues for the two features:

As of writing, they're both open, which makes me suspect either this library no longer requires these features, or it never did (I haven't investigated to understand which it is / why)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant