Use no compression for model layers by default #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add flag --compression to kit pack, with allowed values 'none' and
'gzip'. If 'none' is specified, modelkit layers are stored as tar files
without any compression.
Media types are expanted to support both plain tar and gzip compression.
Add flag --compression to kit pack, with allowed values 'none', 'gzip'
and 'zstd', with a default value of 'gzip'. If 'none' is specified,
modelkit layers are stored as tar files without any compression. If
'zstd' is specified, tarballs are compressed with Zstandard.
Media type are expanded to support plain tar and zstd compression
Expand unpack to support unpacking layers compressed with gzip as well as uncompressed (plain tar) layers.
Add option 'gzip-fastest' to pack compression options. If specified, layers are compressed via gzip at the fastest (i.e. lowest) compression level. In testing, this can speed up compression 2-10x with minimal loss in compression ratio.
amisevsk
force-pushed
the
no-compression-default
branch
from
b9c48f8
to
a4c40cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adapted from the compression-opts branch. See discussion on #257 for details. This PR drops the
zstdoption from that branch.This PR adds the flag
--compressiontokit pack, with valid optionsnone,gzip, andgzip-fastest:none: no compression of layers, store layers as plain tarballsgzip: current default behavior, compress layer tarballs with gzipgzip-fastest: compress layer tarballs with gzip at the lowest compression levelThe new default behavior is
none, i.e. layers are stored in tar format with no compression. In testing, this was found to be a lot faster with minimal effect on modelkit size.In addition, the
gzip-fastestoption is added as testing showed that it could decrease pack time by a factor of 2-10x with minimal loss in compression ratio.Linked issues
Closes #257