Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack tarballs using linux path separators on windows #301

Merged
merged 2 commits into from
May 8, 2024

Conversation

amisevsk
Copy link
Contributor

@amisevsk amisevsk commented May 8, 2024

Description

Store paths in layer tarballs using linux-style paths (i.e. using separator /) on Windows to avoid issues unpacking windows-packed modelkits on Linux/MacOS

Linked issues

Closes #291

To avoid incogruity between platforms, store files in tarballs using
Linux path separators ('/') even on Windows.
Copy link
Contributor

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amisevsk amisevsk merged commit b36f856 into jozu-ai:main May 8, 2024
3 checks passed
@amisevsk amisevsk deleted the support-windows-style-paths branch May 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model layers created on Windows do not unpack correctly on Linux/MacOS
2 participants