-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for proxies #512
Support for proxies #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Generally looks good but there are a few Golang gotchas to handle :)
I'll check and update. |
Co-authored-by: Angel Misevski <misevskia@gmail.com>
@amisevsk Please check, fixed the linting and purged the unnecessary code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
This pr adds support for Proxy in CLI
Linked issues
closes #186