Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for proxies #512

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Support for proxies #512

merged 5 commits into from
Oct 15, 2024

Conversation

srikary12
Copy link
Contributor

Description

This pr adds support for Proxy in CLI

Linked issues

closes #186

@gorkem gorkem requested a review from amisevsk October 7, 2024 13:09
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Generally looks good but there are a few Golang gotchas to handle :)

pkg/lib/constants/consts.go Outdated Show resolved Hide resolved
pkg/cmd/options/network.go Outdated Show resolved Hide resolved
pkg/cmd/options/network.go Outdated Show resolved Hide resolved
@srikary12
Copy link
Contributor Author

I'll check and update.

srikary12 and others added 2 commits October 8, 2024 12:25
Co-authored-by: Angel Misevski <misevskia@gmail.com>
@srikary12
Copy link
Contributor Author

@amisevsk Please check, fixed the linting and purged the unnecessary code.

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@amisevsk amisevsk merged commit a7ff239 into jozu-ai:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for proxies
3 participants