Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make erorr more explicit #515

Merged
merged 2 commits into from
Oct 8, 2024
Merged

make erorr more explicit #515

merged 2 commits into from
Oct 8, 2024

Conversation

TusharMohapatra07
Copy link
Contributor

Description

The error corresponding to kit push was unclear so this contribution is corresponding to making the error more explicit for end user

Linked issues

#510

@@ -118,7 +118,7 @@ func runCommand(opts *pushOptions) func(*cobra.Command, []string) error {
output.Infof("Pushing %s", opts.modelRef.String())
desc, err := PushModel(cmd.Context(), localRepo, remoteRepo, opts)
if err != nil {
return output.Fatalf("Failed to push: %s", err)
return output.Fatalf("Failed to push: %s. Ensure that the organization and repository you are pushing to exist and that you have the necessary write permissions.", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change
"Ensure that the organization and repository you are pushing to exist and that you have the necessary write permissions."

to
"Check you have write permissions to the organization and repository you are pushing to."

@TusharMohapatra07
Copy link
Contributor Author

Please review.

@bmicklea
Copy link
Contributor

bmicklea commented Oct 7, 2024

Message looks good now but I'd like @gorkem to review before we merge. Thanks @TusharMohapatra07!

@TusharMohapatra07
Copy link
Contributor Author

It is still showing that a change is requested. Please verify.

@bmicklea
Copy link
Contributor

bmicklea commented Oct 8, 2024

Congratulations and thank you @TusharMohapatra07 for the PR!

@TusharMohapatra07
Copy link
Contributor Author

Thank you @bmicklea too for your patience and time

@bmicklea bmicklea merged commit 21102b4 into jozu-ai:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants