Added Homebrew Tap Capability #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated platform-release.yaml to include steps required for homebrew tap functionality -updated .goreleaser.darwin.yaml to export MacOS binaries in both .zip and .tar.gz formats - added create-homebrew-recipe.awk - added kitops.rb.template
amisevsk
reviewed
Oct 8, 2024
suggestion from Angel Co-authored-by: Angel Misevski <amisevsk@gmail.com>
Incorporated Angel's feedback
…i/kitops into homebrew-tap-capabilities
Fixed indention issues
removed i386 from supported MacOS builds
amisevsk
approved these changes
Oct 9, 2024
| @@ -1,6 +1,6 @@ | |||
| name: Release with Platform builds | |||
|
|
|||
| on: | |||
| on: | |||
There was a problem hiding this comment.
A few trailing spaces on lines in this file (in VS Code, use cmd+k, cmd+z to trim)
| run: | | ||
| shopt -s failglob | ||
| pushd dist | ||
| shasum -a 256 kitops-* > checksums.txt | ||
| mv checksums.txt kitops_${TAG_NAME}_checksums.txt | ||
| cp kitops_${TAG_NAME}_checksums.txt ../homebrew-files/. |
There was a problem hiding this comment.
unnecessary dot
Suggested change
| cp kitops_${TAG_NAME}_checksums.txt ../homebrew-files/. | |
| cp kitops_${TAG_NAME}_checksums.txt ../homebrew-files/ |
Comment on lines
+285
to
+294
| awk ' | ||
| BEGIN { tag_name = ENVIRON["TAG_NAME"]; repo = ENVIRON["REPO"];} | ||
| /.tar.gz$/ { | ||
| print "\""$1"\"", | ||
| "\"https://github.com/" repo "/releases/download/" tag_name "/" $2 "\"", | ||
| $2, | ||
| tag_name }' kitops_${TAG_NAME}_checksums.txt | | ||
| awk '{ sub(/.tar.gz/, "", $3); print $1, $2, $3, $4 }' | | ||
| awk '{ sub(/kitops-/, "", $3); print $1, $2, $3, $4 }' | | ||
| awk '{sub(/v/, "", $4); print $1, $2, $3, $4 }' > homebrew-metadata.txt |
There was a problem hiding this comment.
I'm taking it on faith that this does whatever it is supposed to -- awk is a write-only language :D
Consider add comments describing what each step does?
Comment on lines
+313
to
+330
| run: | | ||
| cp -f ./homebrew-files/homebrew-metadata.txt ./homebrew-kitops/. | ||
| cp -f ./homebrew-files/kitops.rb ./homebrew-kitops/. | ||
| pushd homebrew-kitops | ||
| CURRENT_BRANCH=$(git rev-parse --abbrev-ref HEAD) | ||
| PR_BRANCH="${{ github.ref_name }}-homebrew-tap-update" | ||
| git fetch origin main | ||
| git branch "$PR_BRANCH" | ||
| git checkout "$PR_BRANCH" | ||
| git pull origin --ff-only "${PR_BRANCH}" || true | ||
| git config --global user.name "${GITHUB_ACTOR}" | ||
| git config --global user.email "${GITHUB_ACTOR_ID}+${GITHUB_ACTOR}@users.noreply.github.com" | ||
| git add --all | ||
| git commit -m "homebrew: update Homebrew Tap Formula for ${{ github.ref_name }}" | ||
| git push origin "${PR_BRANCH}" | ||
| gh pr create --fill --base main --head "${PR_BRANCH}" | ||
| git checkout "${CURRENT_BRANCH}" | ||
| popd |
There was a problem hiding this comment.
This could potentially be simpler using peter-evans/create-pull-request -- IIRC we use this elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issues