Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug in my previous PR. #540

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Fixes a bug in my previous PR. #540

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e989d94
Improve the email field validation in the home page
javisperez Oct 17, 2024
b550fd0
Use a better regexp
javisperez Oct 17, 2024
5780278
Browser doesnt like lookaheads
javisperez Oct 17, 2024
db83d1c
Merge remote-tracking branch 'upstream/main' into 464-ui-update-the-e…
javisperez Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/.vitepress/theme/components/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const subscribeToNewsletter = async () => {
:disabled="isBusy"
id="email"
type="email"
pattern="^[a-zA-Z0-9]+(?:[._+-][a-zA-Z0-9]+)*@[a-zA-Z0-9-]+\.[a-zA-Z]{2,}$"
pattern="^[a-zA-Z0-9]+([._+\-][a-zA-Z0-9]+)*@[a-zA-Z0-9\-]+\.[a-zA-Z]{2,}$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to escape the - -- if it's at the end of the range it's treated as a character (at least in regex parsers I'm familiar with)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats what was my thinking too, but if i dont i get an invalid range error :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check how i escaped both dashes, in the user and in the domain. #fun

name="email"
placeholder="you@example.com"
class="input"
Expand Down