-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to dev UI #629
base: main
Are you sure you want to change the base?
Updates to dev UI #629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good way to test this locally with a running kit dev
server? I tried pnpm dev
but the conversation hangs, and kit dev
is still serving the old one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this file, but the .nvmrc
in frontend/dev-mode
is still on v18.
... also I wasn't able to build it locally using v20 or v22 (pnpm i
was failing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill update the nvmrc thanks for the catch. About running it locally, the way i do it to test it is that i run kit unpack to get a kitfile + model and then do:
kit dev start ./unpacked --port 64246
and then in the frontend/dev-mode/src/services/completion.ts
file i update the apiUrl
const and point it to http://localhost:64246
(change that i dont commit btw), and
pnpm dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh btw i have kit
install via homebrew because is easier, so i just do kit
without using go or anything.
@amisevsk the font size discrepancy i think is expected, I have reused the same code snippets component from the other sites (kitops docs and jozu hub deployment tab) so the snippet style should come from that component, hence the background color, while the left side is just the figma design. I can update the font to be the same on both sites but i'm just trying to avoid having to update the snippet again because "its not the same as kitops". Any thoughts? |
@gorkem i dont understand that question :D what is the also, why are your scrollbars so weird looking? that looks off... ill try to reproduce.. |
@javisperez when we build and package the UI as part of the package it uses https://github.com/javisperez/kitops/blob/8b0364757e5e18dd329022f08e43c9aa38a12605/pkg/lib/harness/generated/gen_common.sh#L6-L15 Can you check if this looks correct? |
I totally forgot about go generate :D We should add it to the frontend readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amisevsk that looks like a bug :flip-the-table: on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes with pnpm preview
and the syntax highlighting is working. On Linux, I'm seeing normal (small) scroll bars.
This PR updates the Dev Mode UI to a new look. With changes in the UX, the flow of the data and useful snippets for Python, Node and SH.