This repository was archived by the owner on May 26, 2020. It is now read-only.
Custom User Models + Tests #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added custom user model wrong password test Cleanup
|
@alvinchow86 this looks great, will soon bump up version and release on pypi. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests, on top of the pull request #18 from @cborgolte . I have a custom user model with USERNAME_FIELD = 'email' (well not that custom but didn't feel like making one from scratch).
One change I made was remove
username_fieldas a class variable from JSONWebTokenSerializer, as it made testing a bit harder (get_user_model() would only be evaluated on module import, and you'd have to do manually reload the module after changing settings.AUTH_USER_MODEL)