Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

Allow jtw_payload_handler to work with User models that don't have an Email field #268

Merged
merged 1 commit into from
May 5, 2017
Merged

Allow jtw_payload_handler to work with User models that don't have an Email field #268

merged 1 commit into from
May 5, 2017

Conversation

shanx
Copy link
Contributor

@shanx shanx commented Oct 5, 2016

I'm using a custom User model that doesn't have an email field. I've made the inclusion of the email field optional in jwt_payload_handler based on whether the attr exists on the model object.

@shanx
Copy link
Contributor Author

shanx commented May 4, 2017

Hey there, just a ping, can these changes be merged?

@angvp
Copy link
Contributor

angvp commented May 4, 2017

Hey @shanx thanks for this PR, sorry it took to long to review it, seems reasonable and useful to me.

@jpadilla since this PR is old want you to have the last word before merge it, :).

@angvp angvp merged commit 8bf295c into jpadilla:master May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants