Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for compressed payloads #753

Merged
merged 8 commits into from
May 19, 2022
Merged

Conversation

danieltmiles
Copy link
Contributor

A bunch of US states are using Smart Health Cards (https://smarthealth.cards/en/) to issue digital proof of COVID-19 vaccination. The QR code on the certificate decodes to a JWT token, but it has a compressed payload and upstream PyJWT didn't handle it. So I offer this contribution.

This patch introduces a dependency on zlib but as an old, salty python developer who hasn't lifted myself out of the requirements.txt era, I haven't figured out how this project is managing dependencies. Can you help me understand what needs to be done?

@auvipy auvipy requested review from jpadilla and auvipy May 1, 2022 17:07
@auvipy auvipy merged commit 675fa10 into jpadilla:master May 19, 2022
@jpadilla
Copy link
Owner

Is this something we can instead provide some kind of hook for? This seems kinda specific use case that I’d think would better live outside this lib

@jpadilla
Copy link
Owner

@auvipy let's revert this please. I'd like to think it through a bit more. Sorry for the last minute comments.

@auvipy
Copy link
Collaborator

auvipy commented May 20, 2022

I am going to revert this for now, but supporting compressed payload may be a future endeaviour

auvipy added a commit that referenced this pull request May 20, 2022
@akx
Copy link
Contributor

akx commented May 23, 2022

It's strange that this was merged when #666 is pending to do the same thing.

auvipy added a commit that referenced this pull request May 23, 2022
@jpadilla
Copy link
Owner

@akx we just reverted this in #761 while we figure a better way to allow third parties to implement things like this.

@russoale
Copy link

@jpadilla Gan you give some update if there is already a way for some sort of callback that can be passed to do this?
Would be open to help

@akx
Copy link
Contributor

akx commented Nov 22, 2022

@russoale Maybe #829 might get merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants