Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed api.header #85

Merged
merged 1 commit into from
Jan 25, 2015
Merged

Removed api.header #85

merged 1 commit into from
Jan 25, 2015

Conversation

mark-adams
Copy link
Contributor

The header function isn't a public part of the API, is not covered by any tests, and really doesn't seem to serve a practical purpose so I propose removing it.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.66%) to 65.14% when pulling 77b806f on mark-adams:remove-header into 9715466 on jpadilla:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.66%) to 65.14% when pulling 77b806f on mark-adams:remove-header into 9715466 on jpadilla:master.

@jpadilla jpadilla added this to the v1.0.0 milestone Jan 25, 2015
@jpadilla
Copy link
Owner

@mark-adams yeah let's get rid of it. Thanks!

jpadilla added a commit that referenced this pull request Jan 25, 2015
@jpadilla jpadilla merged commit f7a6b5f into jpadilla:master Jan 25, 2015
@mark-adams mark-adams deleted the remove-header branch January 25, 2015 13:47
@skion
Copy link
Contributor

skion commented May 8, 2015

Hmm, what is now the suggested way to access the unprotected header before calling decode()?

My use case is that I need access to a kid header which is in turn used as a parameter to decode.

@mark-adams
Copy link
Contributor Author

@skion See #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants