Add complete types to take all allowed keys into account

[Viicos]

Fixes #602, #848, #856, #864 (comment)

I think this is the best we can get, without having to make use of TypeVar/Generic for algorithms. Had to tweak some parts to fix mypy errors.

One possible thing (as stated in #843) could be to add overloads to encode. I'll let you decide on this one, as it can hurt code readability.
Regarding the decode method, it can't be done as a list of allowed algorithms is passed.

[Viicos]

Regarding 16da314, maybe we could switch to from __future__ import annotations in this file as well, to be in line with the rest of the project?

There's also the mypy checks failing, because cryptography can't be found when runing in CI

[Viicos]

Weird to see this is uncovered, maybe we should add a test with a key encoded in bytes? https://github.com/jpadilla/pyjwt/pull/873/files#annotation_10396943799

[auvipy]

can you please check why CI is failing?

[Viicos]

can you please check why CI is failing?

  self = <jwt.api_jwt.PyJWT object at 0x7f36e4b70610>
  payload = {'claim': 'insanity', 'exp': 1681192610, 'iss': 'jeff'}
  now = 1681192613.000076, leeway = 3
  
      def _validate_exp(
          self,
          payload: dict[str, Any],
          now: float,
          leeway: float,
      ) -> None:
          try:
              exp = int(payload["exp"])
          except ValueError:
              raise DecodeError("Expiration Time claim (exp) must be an" " integer.")
      
          if exp <= (now - leeway):
  >           raise ExpiredSignatureError("Signature has expired")
  E           jwt.exceptions.ExpiredSignatureError: Signature has expired
  
  jwt/api_jwt.py:304: ExpiredSignatureError

Seems like this could fail randomly

[auvipy]

can you please describe why this test is removed?

[Viicos]

It's a duplicate of

pyjwt/tests/test_algorithms.py

Lines 758 to 765 in ba72644

	def test_okp_ed25519_should_reject_non_string_key(self):
	algo = OKPAlgorithm()
	with pytest.raises(InvalidKeyError):
	algo.prepare_key(None)
	with open(key_path("testkey_ed25519")) as keyfile:
	algo.prepare_key(keyfile.read())

L764-765

In fact I think it's better to move the two valid checks from test_okp_ed25519_should_reject_non_string_key to this removed test_okp_ed25519_should_accept_unicode_key. Tell me if you want me to do it this way

[Viicos]

Most of the remaining mypy errors are due to the fact that alg.prepare_key/alg.from_jwk can return either a public or a private key. Do you want to keep mypy running for tests and have an explicit assignment for the return types of these methods, or just drop mypy for tests?

[auvipy]

Do you want to keep mypy running for tests and have an explicit assignment for the return types of these methods

yes