Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove algorithm requirement for JWT API #975

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

luhn
Copy link
Contributor

@luhn luhn commented Aug 15, 2024

Followup on #886. Although I updated the JWS API, the JWT API independently requires a non-empty algorithms list. This PR just removes that enforcement entirely—We can rely on the JWS API to make sure an appropriate algorithms list is passed in.

It will rely on JWS API to properly enforce those options.
Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luhn thanks! can you please update the CHANGELOG?

@luhn
Copy link
Contributor Author

luhn commented Aug 26, 2024

Done.

@jpadilla jpadilla merged commit a181e17 into jpadilla:master Aug 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants